[ROCm] eigen patch needed for HIP header changes in r1.15 branch #34769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch is similar to #34770 but differs slightly due to the earlier eigen version used in r1.15 versus master. |
chsigg
approved these changes
Dec 4, 2019
rthadur
added
ready to pull
rthadur
added
ready to pull
|
@jeffdaily can you please check the build failures ? |
gbaned
added
stat:awaiting response
|
Build failures are likely due to the dependent PR #34532 not yet being merged. |
tensorflowbutler
removed
the
stat:awaiting response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is needed to fix the ROCm TensorFlow build for changes currently in HIP master. Since this is the last V1 release branch, it is important to have this feature here. This PR depends on #34532.