Fix GCS filesystem #48222
Merged
Fix GCS filesystem #48222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent changes to enable modular TF can result in breakages or require majority of users to take quick steps to fix their broken code. Instead, we should enable the modular filsystems only if requested by an environment variable and use the legacy behavior in all cases. In a future TF release, the cloud filesystems will come from different pip packages but we have to design the path towards that to ensure that no one in the TF ecosystem is broken by this. As we stand now, without this change most TF users will need to take action in a P0 basis and this is not desirable. CC @yongtang, @kvignesh1420, @vnvo2409. Note that I also changed the name of the envvar to match the logic and you'll have to do the same for SIG IO code. Let's sync on SIG IO meeting to discuss further PiperOrigin-RevId: 365940168 Change-Id: Id03b793613e521999af47fd6017b70ff659bd23b
We want to enable plugins only if the environment variable exists! CC @yongtang, @kvignesh1420, @vnvo2409. PiperOrigin-RevId: 366056903 Change-Id: Ia6f0918c97cbd6e064e19a02ce3a7d46f48b2799
goldiegadde
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherrypicks two changelists.