Embedding Projector: remove knn gpu splitting #6275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicialics
force-pushed
the
knn-computation
branch
from
410754a
to
9ae767d
Compare
alicialics
changed the title
This was referenced Apr 5, 2023
alicialics
force-pushed
the
knn-computation
branch
from
f352506
to
2e8a868
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting an arbitrary vector into 256 parts hurts performance. This change speeds up KNN computation by 3x-5x.
The splitting needs to be done before matrix multiplication step for the cosine similarity computation. Splitting at knn step is already too late. The matrix limit is 2^13 x 2^13 on firefox and 2^14 x 2^14 on chrome (gl.MAX_TEXTURE_SIZE)
Technical description of changes
Remove all code that relates to GPU splitting
Screenshots of UI changes
Detailed steps to verify changes work correctly (as executed by you)
Ran vz_projector_test
Alternate designs / implementations considered