Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

WIP: bugfixes and enhancements to objectives #137

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gabgoh
Copy link
Contributor

@gabgoh gabgoh commented Feb 4, 2019

New formatting for objectives

>>> a   = f(1)
>>> b   = f(2)
>>> c   = f(3)

>>> a                                                                                                
F(1)

>>> b                                                                                                
F(2)

>>> a + 2*b                                                                                               
(F(1) + F(22·-1)

Access to tensors in after objectives is available now

>>> z = a + 2*b   
>>> z(T)
>>> a.value                                                                                            
 <tf.Tensor 'Mean:0' shape=() dtype=float32>

TODO: Realize is a potentially breaking change to the lower levels of the lucid API. Make sure Ludwig is ok with the changes and all unit tests pass.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Copy link
Contributor

@colah colah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will leave this to Ludwig to LGTM, but this looks nice! Welcome to Lucid, Gabe!

lucid/optvis/objectives.py Show resolved Hide resolved
Copy link
Contributor

@ludwigschubert ludwigschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome first contribution! Let's chat details at 3!

lucid/optvis/objectives.py Show resolved Hide resolved
tests/optvis/test_objectives.py Outdated Show resolved Hide resolved
lucid/optvis/objectives.py Show resolved Hide resolved
lucid/optvis/objectives.py Show resolved Hide resolved
@ludwigschubert
Copy link
Contributor

Gabe, please rebase on master@HEAD—I've fixed an unrelated issue with Python 2 compatibility that didn't even let you run the (now still failing) tests in the Python 2 env.

lucid/optvis/objectives.py Show resolved Hide resolved
lucid/optvis/objectives.py Show resolved Hide resolved
lucid/optvis/objectives.py Show resolved Hide resolved
@gabgoh
Copy link
Contributor Author

gabgoh commented Feb 4, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@gabgoh gabgoh force-pushed the objectives_enhancements branch 2 times, most recently from 1ca9496 to 852b1e9 Compare February 4, 2019 23:50
@ludwigschubert
Copy link
Contributor

ludwigschubert commented Mar 12, 2021

@gabgoh I'd still happily merge this, but I need a little bit of help. Can you rebase on tensorflow/lucid HEAD? Or transfer the branch from your fork to this repository so I can do so myself?

@ludwigschubert ludwigschubert marked this pull request as draft March 12, 2021 15:34
@ludwigschubert ludwigschubert self-assigned this Mar 12, 2021
@ludwigschubert ludwigschubert added awaiting reply Waiting for third-party reply lucid.optvis labels Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting reply Waiting for third-party reply lucid.optvis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants