-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create v0 and experimental namespace for python #603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is part of the effort to clean up the namespace for python. Quite a few files have been changed but the only real changes are: 1) Created a namespace of `tfio.experimental` for future usage 2) Created a namespace of `tfio.v0` to indicate the current release namespace 3) Alias all `tfio.v0` namespace to `tfio`, so that no end user impact. For example, tfio.IODataset.from_audio is an alias of tfio.v0.IODataset.from_audio and could be used concurrently. This PR is part of the discussion in 553. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
…t.from_prometheus instead) Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
…instead) Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
…ntal.IODataset.from_libsvm Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@terrytangyuan @BryanCutler This PR is ready for review. Would you mind taking a look and see if the api namespace layout makes sense? |
terrytangyuan
approved these changes
Nov 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
SGTM! |
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
* Create v0 and experimental namespace for python This PR is part of the effort to clean up the namespace for python. Quite a few files have been changed but the only real changes are: 1) Created a namespace of `tfio.experimental` for future usage 2) Created a namespace of `tfio.v0` to indicate the current release namespace 3) Alias all `tfio.v0` namespace to `tfio`, so that no end user impact. For example, tfio.IODataset.from_audio is an alias of tfio.v0.IODataset.from_audio and could be used concurrently. This PR is part of the discussion in 553. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Fix several breaks Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Move prometheus to core to free up tfio.prometheus (use tfio.IODataset.from_prometheus instead) Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Move pcap to core to free up tfio.pcap (use tfio.IODataset.from_pcap instead) Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Fix issue Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Remap Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Move libsvm to tfio.experimental.text.decode_libsvm and tfio.experimental.IODataset.from_libsvm Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Fix version string Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Update to remove unneeded prefix Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Fix typo in test Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the effort to clean up the namespace
for python. Quite a few files have been changed but the only real
changes are:
tfio.experimental
for future usagetfio.v0
to indicate the current release namespacetfio.v0
namespace totfio
, so that no end user impact.For example, tfio.IODataset.from_audio is an alias of tfio.v0.IODataset.from_audio
and could be used concurrently.
tfio.experimental.IODataset.from_libsvm
andtfio.experimental.text.decode_libsvm
, to setup an initial example.Overall, this is a poor man's version of API namespace management (compared to core tensorflow's API namespace management).
Below are the output of APIs. As we could see API namespace has been much cleaned up:
This PR is part of the discussion in #553.
Signed-off-by: Yong Tang yong.tang.github@outlook.com