Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[*.ipynb] blacken #2620

Closed
wants to merge 1 commit into from
Closed

Conversation

SamuelMarks
Copy link
Contributor

Description

python -m black at 21.12b0

Brief Description of the PR:

Since July—psf/black#2357 —black now formats jupyter notebook (pip install black[jupyter]). So let's apply this.

Related: tensorflow/tensorflow#53360

Type of change

  • Bug fix

Checklist:

How Has This Been Tested?

N/A

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seanpmorgan
Copy link
Member

Per conversation in the bi-monthly grooming meeting, we're currently pinned to the formatting required in TF docs. Here is our CI:
https://github.com/tensorflow/addons/blob/master/.github/workflows/ci_test.yml#L98-L111

Definitely encourage the use of black and please tag us in the tensorflow/tensorflow docs issue to see if this can be supported for all TF repositories.

@seanpmorgan
Copy link
Member

cc @MarkDaoust

@MarkDaoust
Copy link
Member

Autoformatting the python-source in notebooks is nice.

To do this for real I'd want to run black from inside our current tool, since the json formatting is ~inline with what Colab saves.
That's possible but I'd have to update google's internal version of black. It's doable, but it would take some work.

@SamuelMarks
Copy link
Contributor Author

@MarkDaoust Sure happy to help, just give me access (I've signed the Google NDA as I'm a GDE)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants