Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore single class MatthewsCorrelationCoefficient test cases #2494

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented Jun 2, 2021

Description

This PR restores single class tests for MatthewsCorrelationCoefficient. These tests have been removed in #2406 which unfortunately broke MatthewsCorrelationCoefficient with num_classes=1. This was a breaking change which doesn't seem like it was intended. These test will currently fail on master but passed in 0.12.1 (or any version before #2406).

Please consider this PR as an issue report. Unfortunately I don't have time time right now to properly look into fixing this issue, but maybe @jonpsy knows more about this. fixed in #2495

/cc @jonpsy @bhack @seanpmorgan

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

@lgeiger lgeiger requested a review from autoih as a code owner June 2, 2021 16:48
@boring-cyborg boring-cyborg bot added the metrics label Jun 2, 2021
@google-cla google-cla bot added the cla: yes label Jun 2, 2021
@bot-of-gabrieldemarmiesse

@autoih @marload

You are owners of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants