Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Build arm64 for macOS in CI wip #414

Closed
wants to merge 4 commits into from
Closed

chore: Build arm64 for macOS in CI wip #414

wants to merge 4 commits into from

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jun 17, 2022 •
edited

Fix #340

Signed-off-by: Ce Gao cegao@tensorchord.ai

@gaocegege
chore: Build arm64
66a41c0 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege
test
659a791 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege
fix: Remove debug
e715a56 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege
Update
5d099c4 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege gaocegege requested a review from VoVAllen June 17, 2022 02:02
@gaocegege gaocegege changed the title chore: Build arm64 chore: Build arm64 for macOS in CI Jun 17, 2022
VoVAllen
VoVAllen reviewed Jun 17, 2022
View reviewed changes
.github/workflows/release.yml
@@ -75,7 +75,8 @@ jobs:
- name: Build wheels
uses: pypa/cibuildwheel@v2.6.1
env:
CIBW_ARCHS: auto64
CIBW_ARCHS_MACOS: "x86_64 universal2 arm64"
CIBW_ARCHS_LINUX: "x86_64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the arch of envd? How is it configured?

@gaocegege gaocegege changed the title chore: Build arm64 for macOS in CI chore: Build arm64 for macOS in CI wip Jun 17, 2022
@gaocegege
Copy link
Member Author

I think we should postpone the PR since I have no way to test if the PR works well. We need a M1 macOS to verify the wheel can be installed and the envd bin can be run successfully.

@popfido
Copy link
Member

popfido commented Jun 20, 2022

I think we should postpone the PR since I have no way to test if the PR works well. We need a M1 macOS to verify the wheel can be installed and the envd bin can be run successfully.

How to test it lol. I can help if possible.

@gaocegege
Copy link
Member Author

@popfido
Thanks! I think we should establish the mechanism to continuous integration with M1 chip macOS, instead of test it manually.

Thus I prefer to find a way to setup M1 CI for envd.

But, thanks for your interest!

@aseaday
Copy link
Member

aseaday commented Jun 30, 2022

How about this https://veertu.com/?

@gaocegege
Copy link
Member Author

How about this https://veertu.com/?

Will have a look at it. Seems helpful to us.

@gaocegege gaocegege mentioned this pull request Jul 1, 2022
Closed
@TaylorHere
Copy link

https://github.blog/changelog/2021-08-16-github-actions-macos-11-big-sur-is-generally-available-on-github-hosted-runners/
This post may be helpful

@gaocegege gaocegege closed this Nov 28, 2022
@gaocegege
Copy link
Member Author

I will implement this in the new PR #1236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoVAllen VoVAllen VoVAllen left review comments

@kemingy kemingy Awaiting requested review from kemingy kemingy is a code owner

Assignees

@VoVAllen VoVAllen

Labels
None yet
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: arm64 binaries are not available on PyPI
5 participants
@gaocegege @popfido @aseaday @TaylorHere @VoVAllen