e2e: add abci delays #9254
e2e: add abci delays #9254
Conversation
test/e2e/pkg/testnet.go
Outdated
| PrepareProposalDelayMS int | ||
| ProcessProposalDelayMS int | ||
| CheckTxDelayMS int |
There was a problem hiding this comment.
Why not just use durations directly for the type?
Additionally, consider using a struct to contain these.
type ABCIDelays struct {
PrepareProposal
...
}
There was a problem hiding this comment.
Does TOML support durations or are you suggesting I just convert it after parsing the toml file?
There was a problem hiding this comment.
Our toml parser supports parsing duration strings into go durations.
see
There was a problem hiding this comment.
Let me change it up then
| @@ -5,6 +5,7 @@ import ( | |||
| "math/rand" | |||
| "sort" | |||
| "strings" | |||
| "time" | |||
|
|
|||
| e2e "github.com/tendermint/tendermint/test/e2e/pkg" | |||
| ) | |||
There was a problem hiding this comment.
testnetCombinations defined in line 15 was adding the possibility to test "builtin" and "out of process".
This also modified nodeABCIProtocols in line 29 (BTW, looks like we are not testing GRPC as it is now?).
Do we want to backport this change in structure of the variables controlling the test combinations?
There was a problem hiding this comment.
gRPC seems to have been purposefully disabled due to #5439. It's hard to judge whether this is still an issue
There was a problem hiding this comment.
We can look to port more of the e2e functionality later. I kind of want to pick off important chunks first
There was a problem hiding this comment.
Agreed. Anyway remember that this effort is not in the critical path (i.e., it's not blocking the creation of branch v0.37.x). IOW, it can proceed along with the release QA process
|
Contributes to #9053 |
This ports the changes made in: #8638
This does not completely port over the changes as there are also delays to vote extensions and finalize block which haven't been captured. I will open an issue to track those