Work around a permissions bug in actions/checkout. #8339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind opening an issue to track changing this back? |
williambanfield
approved these changes
Apr 13, 2022
Will do. First I have to find a workaround that actually works 🙂 |
creachadair
force-pushed
the
mjf/ownership
branch
from
17438eb
to
d7cdb99
Compare
This PR works around two issues causing the markdown link check to fail in CI. 1. actions/checkout#760. A git permissions issue, apparently triggered by a combination of a git change and the behaviour of actions/checkout. 2. gaurav-nelson/github-action-markdown-link-check#129. Merging an updated version of the underlying package that fixes a bug in the handling of local #anchors. The workaround is a temporary patched fork of the link-checker action. This should be removed once the upstream issues are addressed.
creachadair
force-pushed
the
mjf/ownership
branch
from
d7cdb99
to
00372ef
Compare
creachadair
requested review from
ebuchman,
cmwaters,
tychoish,
sergio-mena,
jmalicevic,
thanethomson and
ancazamfir
as code owners
cmwaters
approved these changes
Apr 13, 2022
| @@ -16,7 +16,7 @@ jobs: | |||
| with: | |||
| PATTERNS: | | |||
| **/**.md | |||
| - uses: gaurav-nelson/github-action-markdown-link-check@1.0.14 | |||
| - uses: creachadair/github-action-markdown-link-check@master | |||
There was a problem hiding this comment.
No secret here, it's a fork!
creachadair
pushed a commit
that referenced
this pull request
Apr 28, 2022
In #8339 we pointed the markdown link checker action to a patched version that has the up-to-date version of the underlying check tool. In doing so, I missed the periodic cron job that runs the same workflow. Update it to use the patched version also.
creachadair
pushed a commit
that referenced
this pull request
Apr 28, 2022
In #8339 we pointed the markdown link checker action to a patched version that has the up-to-date version of the underlying check tool. In doing so, I missed the periodic cron job that runs the same workflow. Update it to use the patched version also.
tychoish
pushed a commit
that referenced
this pull request
Apr 28, 2022
In #8339 we pointed the markdown link checker action to a patched version that has the up-to-date version of the underlying check tool. In doing so, I missed the periodic cron job that runs the same workflow. Update it to use the patched version also.
tychoish
pushed a commit
to tychoish/tendermint
that referenced
this pull request
Apr 29, 2022
In tendermint#8339 we pointed the markdown link checker action to a patched version that has the up-to-date version of the underlying check tool. In doing so, I missed the periodic cron job that runs the same workflow. Update it to use the patched version also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around markdown-link-check issues.
This PR works around two issues causing the markdown link check to fail in CI.
fatal: unsafe repository (REPO is owned by someone else)with ubuntu 20.04 container actions/checkout#760. A git permissions issue,apparently triggered by a combination of a git change and the behaviour of
actions/checkout.
Upgrade to markdown-link-check@3.10.0 gaurav-nelson/github-action-markdown-link-check#129.
Merging an updated version of the underlying package that fixes a bug in the
handling of local #anchors.
The workaround is a temporary patched fork of the link-checker action. This
should be removed once the upstream issues are addressed.