Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: allow node operator to rollback last state #7033
cli: allow node operator to rollback last state #7033
Changes from 12 commits
d84455a
e3f0169
1356f03
485f6dc
84b5e45
49ee521
138539d
aa41072
4bd8b2f
dfe0ca1
581dac5
a79a9e8
a4b7e25
0d267cf
bd57101
ee95a52
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the libs/cli package is really just helpers for managing/using cobra, and so this is sort of a weird case.
I think this should end up in either:
node
cmd/tendermint/commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think putting it in
node
makes sense because that should be node-only stuff. I initially had it incmd/tendermint/commands
but this feels also strange because it's not a command, rather some tooling function. Maybe we just have to face that there's probably no idea home for it and leave it incmd/tendermint/commands
.