New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fastsync: update the metrics during fast-sync #6590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for now, Im not the biggest fan of passing the consensus state as we are doing.
This made me think that there may be some metrics that other reactors may want to touch, does it make sense to have node pkg metrics that various reactors can update depending on the various states of a node?
Codecov Report
@@ Coverage Diff @@
## master #6590 +/- ##
==========================================
+ Coverage 61.04% 61.07% +0.02%
==========================================
Files 295 295
Lines 27968 27956 -12
==========================================
Hits 17074 17074
+ Misses 9166 9157 -9
+ Partials 1728 1725 -3
|
db73170
to
8ef165a
Compare
8ef165a
to
f0b0655
Compare
Closes #3507