Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: add sr25519 as a validator key #6376

Merged
merged 9 commits into from Apr 22, 2021
Merged

crypto: add sr25519 as a validator key #6376

merged 9 commits into from Apr 22, 2021

Conversation

tac0turtle
Copy link
Contributor

Description

Add sr25519 as a validator key option. We support the crypto in tendermint and added batch verification recently.

@tac0turtle tac0turtle added the C:crypto Component: Crypto label Apr 20, 2021
@tac0turtle tac0turtle self-assigned this Apr 20, 2021
tac0turtle
tac0turtle commented Apr 20, 2021
View reviewed changes
crypto/encoding/codec.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle marked this pull request as ready for review April 20, 2021 14:30
@tac0turtle tac0turtle requested review from cmwaters and alexanderbez and removed request for alexanderbez April 20, 2021 14:30
webmaster128
webmaster128 reviewed Apr 20, 2021
View reviewed changes
Copy link

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you

crypto/encoding/codec.go Outdated Show resolved Hide resolved
types/params.go Outdated Show resolved Hide resolved
types/params.go Outdated Show resolved Hide resolved
types/params_test.go Outdated Show resolved Hide resolved
@tac0turtle @webmaster128
Apply suggestions from code review
808f096 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
webmaster128
webmaster128 reviewed Apr 20, 2021
View reviewed changes
CHANGELOG_PENDING.md Outdated Show resolved Hide resolved
types/params_test.go Show resolved Hide resolved
@tac0turtle @webmaster128
Update CHANGELOG_PENDING.md
af760f3 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
alexanderbez
alexanderbez suggested changes Apr 20, 2021
View reviewed changes
abci/types/pubkey.go Outdated Show resolved Hide resolved
crypto/encoding/codec.go Outdated Show resolved Hide resolved
types/params.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle added the S:automerge Automatically merge PR when requirements pass label Apr 21, 2021
@cmwaters
Copy link
Contributor

Does this test failing have anything to do with your changes:

--- FAIL: TestNonEd25519Pubkey (0.01s)
    secret_connection_test.go:282: 
        	Error Trace:	secret_connection_test.go:282
        	Error:      	An error is expected but got nil.
        	Test:       	TestNonEd25519Pubkey
FAIL

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #6376 (a6e5b1e) into master (aa93ad8) will increase coverage by 0.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6376      +/-   ##
==========================================
+ Coverage   60.58%   60.82%   +0.24%     
==========================================
  Files         283      283              
  Lines       26917    26925       +8     
==========================================
+ Hits        16307    16378      +71     
+ Misses       8893     8844      -49     
+ Partials     1717     1703      -14
Impacted Files Coverage Δ
abci/types/pubkey.go 0.00% <0.00%> (ø)
p2p/conn/secret_connection.go 84.02% <ø> (+1.03%) ⬆️
types/params.go 80.55% <ø> (ø)
mempool/reactor.go 73.04% <0.00%> (-2.84%) ⬇️
p2p/transport_memory.go 85.13% <0.00%> (-2.71%) ⬇️
blockchain/v2/reactor.go 32.04% <0.00%> (-1.41%) ⬇️
statesync/syncer.go 78.65% <0.00%> (-0.80%) ⬇️
blockchain/v0/pool.go 77.18% <0.00%> (-0.77%) ⬇️
proxy/multi_app_conn.go 48.05% <0.00%> (ø)
p2p/router.go 77.29% <0.00%> (+0.24%) ⬆️
... and 10 more

@mergify mergify bot merged commit 990504c into master Apr 22, 2021
@mergify mergify bot deleted the marko/add_sr25519 branch April 22, 2021 10:37
@tzemanovic tzemanovic mentioned this pull request Nov 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@tessr tessr Awaiting requested review from tessr

@tychoish tychoish Awaiting requested review from tychoish

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@tac0turtle tac0turtle

Labels
C:crypto Component: Crypto S:automerge Automatically merge PR when requirements pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tac0turtle @cmwaters @webmaster128 @alexanderbez