Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

bump protobuf version #68

Merged
merged 4 commits into from Jun 14, 2019
Merged

bump protobuf version #68

merged 4 commits into from Jun 14, 2019

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Jun 13, 2019

as https://github.com/RustSec/advisory-db/blob/master/crates/protobuf/RUSTSEC-2019-0003.toml

@liamsi @marbar3778 I noticed that the current repo has Cargo.lock in .gitignore -- is that desired?

Copy link
Contributor

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we rather use the latest release (2.6.2) instead (and regenerate the rust code using that release)?

Regarding the lock file, https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html states that

If you’re building a non-end product, such as a rust library that other rust packages will depend on, put Cargo.lock in your .gitignore. If you’re building an end product, which are executable like command-line tool or an application, or a system library with crate-type of staticlib or cdylib, check Cargo.lock into git.

rust-abci is more of a library and not an end-product. At the same time, I think adding the cargo lock file would increase reproducibility. Which seems important for rust-abci IMHO. Let's discuss this in a separate issue.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
tomtau and others added 3 commits June 14, 2019 08:59
Co-Authored-By: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Co-Authored-By: Ismail Khoffi <Ismail.Khoffi@gmail.com>
@tomtau tomtau mentioned this pull request Jun 14, 2019
@tomtau
Copy link
Contributor Author

tomtau commented Jun 14, 2019

@liamsi regenerated and opened this issue: #70

Copy link
Contributor

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liamsi liamsi merged commit b7ee2f8 into tendermint:develop Jun 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants