Add clippy (#67) and cleanup dependencies

* Added Clipp
* removed mockstream
* updated rust-protobuf and regenerated the message files with it

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>

.circleci/config.yml

@@ -14,6 +14,11 @@ jobs:
             rustup component add rustfmt-preview
             rustfmt --version
             cargo fmt -- --check --color=auto
+      - run:
+          name: Check Linting
+          command: |
+            rustup component add clippy
+            cargo clippy
       - run:
           name: Nightly Build
           command: |

CONTRIBUTING.md

@@ -43,6 +43,7 @@ The code should follow [Rust Style Guide](https://github.com/rust-lang/rfcs/tree
 Before opening a Pull Request please run the checks below:
 
 * Install rustfmt: `rustup component add rustfmt`
+* Install clippy: `rustup component add clippy`
 
 ### Testing 
 
@@ -56,6 +57,12 @@ Make sure your code is well-formatted by running
 
 ```cargo fmt```
 
+### Lint (clippy)
+
+Lint your code (i.e. check it for common issues) with:
+
+```cargo clippy```
+
 ## License
 
 Copyright © 2018-2019 Tendermint

Cargo.toml

@@ -15,7 +15,6 @@ bytes = "0.4"
 protobuf = "2.2.0"
 byteorder = "1.2.7"
 integer-encoding = "1.0.5"
-mockstream = "0.0.3"
 log = "0.4.6"
 env_logger = "0.6.1"
 tokio = "0.1"

src/codec.rs

@@ -41,7 +41,7 @@ impl Encoder for ABCICodec {
 
     fn encode(&mut self, msg: Response, buf: &mut BytesMut) -> Result<(), Box<Error>> {
         let msg_len = msg.compute_size();
-        let varint = i64::encode_var_vec(msg_len as i64);
+        let varint = i64::encode_var_vec(i64::from(msg_len));
 
         let remaining = buf.remaining_mut();
         let needed = msg_len as usize + varint.len();

src/lib.rs

@@ -27,7 +27,6 @@ extern crate integer_encoding;
 #[macro_use]
 extern crate log;
 extern crate core;
-extern crate mockstream;
 extern crate protobuf;
 extern crate tokio;