DT-1740 - update workflow reset UI for new reapply types in 1.24 #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossedfort
requested review from
stevekinney,
Alex-Tideman and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/lib/i18n/locales/en/workflows.ts
Outdated
Comment on lines
93
to
94
| 'reset-exclude-signals': 'Exclude signals that occur after the reset point.', | ||
| 'reset-exclude-updates': 'Exclude updates that occur after the reset point.', |
There was a problem hiding this comment.
Let's capitalize Signals and Updates here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
in temporal server version 1.24, a new API will be available for resetting workflows that supports reapplying Updates after the reset point, in addition to Signals. This PR makes the changes necessary to the UI support this new option. Note - the behavior is inverse, i.e. the API expects opting out of reapplies as opposed to opting in.
RESET_REAPPLY_TYPE_SIGNAL, if unchecked sendRESET_REAPPLY_TYPE_NONEinresetReapplyTypefieldRESET_REAPPLY_EXCLUDE_TYPE_SIGNAL, if only “Exclude updates” is checked, sendRESET_REAPPLY_EXCLUDE_TYPE_UPDATE. If both are checked send both, if none are checked, sendRESET_REAPPLY_EXCLUDE_TYPE_UNSPECIFIEDinresetReapplyExcludeTypesfieldScreenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?