Skip to content

Commit

Permalink
Fixing flaky TestWorkflowReplicationTaskFailure (#5880)
Browse files Browse the repository at this point in the history
## What changed?
Fixing flaky TestWorkflowReplicationTaskFailure by increasing timeout.

## Why?
It looks like test timeout is not enough for the history events to get
replicated and DLQed.
Increasing the timeout from 30s to 1m. 

## How did you test it?


## Potential risks


## Documentation

## Is hotfix candidate?
No
  • Loading branch information
prathyushpv committed May 9, 2024
1 parent e96a6fa commit 7d05e8f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/xdc/history_replication_dlq_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ func (s *historyReplicationDLQSuite) TestWorkflowReplicationTaskFailure() {
// replication, so we use a context with a timeout to ensure that the test doesn't hang forever when we try to
// receive from a channel.
ctx := context.Background()
ctx, cancel := context.WithTimeout(ctx, testTimeout)
ctx, cancel := context.WithTimeout(ctx, time.Minute)
defer cancel()

// Register a namespace.
Expand Down

0 comments on commit 7d05e8f

Please sign in to comment.