Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated node version warning #39

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

bergundy
Copy link
Member

@bergundy bergundy commented Dec 7, 2022

No description provided.

@vercel
Copy link

vercel bot commented Dec 7, 2022

@bergundy is attempting to deploy a commit to the Temporal Team on Vercel.

To accomplish this, @bergundy needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@kimschles
Copy link
Contributor

Hi @bergundy 👋🏻
I just tested the command npx @temporalio/create@latest ./my-app with Node.js versions:

  • 18.6.0
  • 18.7.0
  • 18.8.0
  • 18.9.0
  • 18.12.1

and I'm still seeing this error:

Aborting installation.
Unexpected error. Please report it as a bug:
DownloadError: Premature close
    at createApp (file:///Users/kim/.npm/_npx/84edb3507a773a27/node_modules/@temporalio/create/lib/create-project.js:136:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async start (file:///Users/kim/.npm/_npx/84edb3507a773a27/node_modules/@temporalio/create/lib/index.js:121:5)

When I tested this last month, it was an issue related to temporalio/sdk-typescript#905, and the changes to fix the node-tar package were pushed out to some versions of npm, but not the versions used with those Node.js versions above.

Since the issue still persists, should we change the warning to flag the versions of npm that weren't patched? Let me know what you think.

@bergundy
Copy link
Member Author

bergundy commented Dec 8, 2022

Try npm cache clean --force and rerun.

@bergundy bergundy merged commit f876dae into main Dec 9, 2022
@bergundy bergundy deleted the outdated-node-version-warning branch December 9, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants