Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable eager activities if tq rate limits is set #1350

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Disable eager activities if tq rate limits is set #1350

merged 1 commit into from
Jan 17, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Jan 13, 2024 •
edited

Currently server does not properly rate limit eager activities. Disabling for now until the Server can address this.

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner January 13, 2024 18:01
@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as draft January 13, 2024 18:01
@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review January 16, 2024 18:39
Sushisource
Sushisource approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Is there an item for this in Core? Or a more general one I can link to if I make one for Core?

@Quinn-With-Two-Ns Quinn-With-Two-Ns mentioned this pull request Jan 16, 2024
Open
3 tasks
@Quinn-With-Two-Ns
Copy link
Contributor Author

@Sushisource I opened this temporalio/features#405

@Quinn-With-Two-Ns Quinn-With-Two-Ns force-pushed the disable-eager-activities-with-tq-rate-limit branch from a932549 to fb57506 Compare January 17, 2024 17:11
@Quinn-With-Two-Ns
Disable eager activities if tq rate limits is set
bb0286e 
Currently server does not properly rate limit eager activities.
Disabling for now until the Server can address this.
@Quinn-With-Two-Ns Quinn-With-Two-Ns force-pushed the disable-eager-activities-with-tq-rate-limit branch from fb57506 to bb0286e Compare January 17, 2024 18:50
@bergundy
Copy link
Member

Makes sense. Is there an item for this in Core? Or a more general one I can link to if I make one for Core?

There isn't an issue for this in Core but I opened a related issue a few days ago for worker-local rate limits with eager activities: temporalio/sdk-core#669.

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 55c39b5 into temporalio:master Jan 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Quinn-With-Two-Ns @bergundy @cretz @Sushisource