Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MVP .NET referential feature & inter-tech how-to documentation #2769
MVP .NET referential feature & inter-tech how-to documentation #2769
Changes from 3 commits
dc162fb
cbb444e
b986d77
6c10209
3044eab
917d528
9d1d846
4f322a1
00ca8f0
6529f31
8e55267
0d6e6c4
a1f0417
6fceacb
0160590
ed7a922
40441f4
483dbfe
d0128b9
1d68577
b7b67c9
a480534
21f66de
4c599d7
701dd27
068e777
5a6849b
04c947b
b041bfe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting cancellation of a workflow is a different concept than requesting cancellation of an activity, so I am splitting these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conversion not capitalized here but it is with Data Conversion below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure if "Type" should be capitalized in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be here, I think it should be with the testing documentation. It's not about durable timers a user may create, it's also about timeouts and other things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is expected to be put under this heading? The next heading is not a child. Is there existing SDK documentation you can point to as a guide so we can be consistent here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of this document is failure detection but we often don't consider timeouts the same as failures. Also, not sure these general purpose options are about failure detections. I think they deserve to be next to other workflow options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent headings with workflow timeouts (this is prefixed with "How to set" but "Workflow timeouts" section is not)