Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warnings around mentions of npx @temporalio/create@latest/ #1667

Closed
wants to merge 1 commit into from

Conversation

chitalian
Copy link

What does this PR do?

Alerting users about a Node 18 regression and showing alternative solutions.

Notes to reviewers

There seems to be a regression in node 18 and running npx @temporalio/create@latest/ does not seem to work.

@chitalian chitalian requested review from a team and lorensr as code owners October 9, 2022 01:17
@vercel
Copy link

vercel bot commented Oct 9, 2022

@chitalian is attempting to deploy a commit to the Temporal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2022

CLA assistant check
All committers have signed the CLA.

@rachfop
Copy link
Contributor

rachfop commented Oct 13, 2022

I'm going to leave this PR up in case someone else runs into the same problem. But this is being tracked here: temporalio/sdk-typescript#905

I'd rather not add these directly to the docs, just to remove it when the tar issue is fixed.

But we sincerely appreciate the doc update!

@bergundy
Copy link
Member

I'd rather not put this warning all over the docs, hopefully the tar issue will be resolved soon.

@chitalian
Copy link
Author

sounds good to me, thanks for getting back to me on this

@bergundy
Copy link
Member

node-tar issue is resolved, closing this issue

@bergundy bergundy closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants