Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update README #17

wants to merge 2 commits into from

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Feb 4, 2022 •
edited

What was changed

Added docker build details

Why?

Visibility and info into the Docker images build process
Plus temporalio/temporal#2456 (comment)

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@feedmeapples feedmeapples mentioned this pull request Feb 4, 2022
Merged
alexshtin
alexshtin reviewed Feb 4, 2022
View reviewed changes
Copy link
Member

@alexshtin alexshtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually an interesting problem. How to build and run docker image from your local changes? This needs to be think through and documented properly, not just copied from main repo.

README.md Outdated Show resolved Hide resolved
README.md

## Build docker image for any commit

Replace **YOUR_TAG** and **YOUR_CHECKOUT_COMMIT** to build manually:
Refer to [docker-builds](https://github.com/temporalio/docker-builds) to build the images manually.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in docker-builds repo.

@feedmeapples @alexshtin
Update README.md
6e49dbb 
Co-authored-by: Alex Shtin <alex@shtin.com>
@robholland
Copy link
Contributor

I suggest closing this, I don't think the content is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin alexshtin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@alexshtin alexshtin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@feedmeapples @robholland @alexshtin