Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AssignedBuildId to workflow describe #559

Merged
merged 4 commits into from
May 17, 2024

Conversation

ShahabT
Copy link

@ShahabT ShahabT commented May 10, 2024

What was changed

workflow describe now shows WF's assigned build ID as follows:

$temporal --env shahab-test4 workflow describe --workflow-id b72b1a82-7a83-4cc9-9bde-6ad8d411a47c      
Execution Info:
  WorkflowId            b72b1a82-7a83-4cc9-9bde-6ad8d411a47c
  RunId                 c81a42c2-efc1-4c41-9088-a0123c0d1034
  Type                  MyWorkflow
  Namespace             shahab-test4.temporal-dev
  TaskQueue             my-tq
  AssignedBuildId       BUILD_ID_HERE
  StartTime             4 hours ago
  ExecutionTime         4 hours ago
  SearchAttributes      map[BuildIds:metadata:{key:"encoding" value:"json/plain"} metadata:{key:"type" value:"KeywordList"} data:"[\"assigned:C\",\"versioned:C\"]"]
  StateTransitionCount  2
  HistoryLength         2
  HistorySize           263

Why?

This is an important attribute for WFs running on versioned workers.

Checklist

  1. Closes

  2. How was this tested:

Unit test added.

  1. Any docs updates needed?

No.

@CLAassistant
Copy link

CLAassistant commented May 10, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ShahabT
Copy link
Author

ShahabT commented May 10, 2024

Waiting for #556 to merge first.

@ShahabT ShahabT changed the base branch from main to versioning-2 May 10, 2024 23:48
@ShahabT ShahabT marked this pull request as ready for review May 13, 2024 16:15
@ShahabT ShahabT merged commit 526753a into versioning-2 May 17, 2024
0 of 6 checks passed
@ShahabT ShahabT deleted the shahab/assigned-build-id branch May 17, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants