Exit zero if help/version is explicitly requested #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want a non-zero exit when the user invokes `temporal` with an unknown command/subcommand, or when invoked with no arguments. But if the user explicitly asks for help, we should print it and return success. Closes #495.
Sushisource
approved these changes
Apr 5, 2024
cretz
reviewed
Apr 5, 2024
🤦 It even listed |
josh-berry
changed the title
cretz
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want a non-zero exit when the user invokes
temporalwith an unknown command/subcommand, or when invoked with no arguments. But if the user explicitly asks for help or version information, we should print it and return success.Closes #495.