Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for react-router v5 Link components #1422

Merged
merged 5 commits into from Mar 25, 2020

Conversation

jraff
Copy link
Contributor

@jraff jraff commented Mar 24, 2020

Related issues

See #1401

Description

Add support for react-router v5 Link to

  • ButtonLink
  • Breadcrumbs
  • Link
  • ChevronLink

Checklist before submitting pull request

  • New code is unit tested
  • Commits follow our Developer Guide
  • For code changes, run npm run prepr locally
    • make sure visual and accessibility tests pass

@TDSBot
Copy link

TDSBot commented Mar 24, 2020

Packages pending updates:

- @tds/core-breadcrumbs: 2.2.1 => 2.2.2
- @tds/core-button-link: 2.1.14 => 2.1.15
- @tds/core-chevron-link: 2.1.14 => 2.1.15
- @tds/core-link: 2.2.4 => 2.2.5
- @tds/core-terms-and-conditions: 1.2.21 => 1.2.22

If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

Copy link
Contributor

@marcod1419 marcod1419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marcod1419 marcod1419 merged commit d30d356 into master Mar 25, 2020
@marcod1419 marcod1419 deleted the 1754-react-router-link-component-prop-type branch March 25, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants