Extend dialogue storages with RocksDB #753
Conversation
xamgore
force-pushed
the
rocksdb-storage
branch
6 times, most recently
from
130517b
to
4b6c97b
Compare
| types::ChatId, | ||
| }; | ||
|
|
||
| #[tokio::test(flavor = "multi_thread")] |
There was a problem hiding this comment.
Is there a particular reason to use flavor = "multi_thread"?
There was a problem hiding this comment.
Honestly, I have just copied tests from tests/sqlite.rs, but can't find any arguments for it. Should I remove it?
There was a problem hiding this comment.
Ah, if this already existed then this can be left to a followup PR. I think we could have a function like test_storage() (or a number of functions anyway...) so that we test all storages in the same exact way.
xamgore
force-pushed
the
rocksdb-storage
branch
from
4b6c97b
to
d75b465
Compare
|
@WaffleLapkin @Hirrolot I have also changed |
There was a problem hiding this comment.
This looks good to me, however @Hirrolot knows the storages better, so I'd wait for his review.
|
Thanks for submitting a useful feature, @xamgore! |
Extend dialogue storages with RocksDB Former-commit-id: 926b8ef
The implementation is straightforward and uses a
MultiThreaddatabase instance. Thedelete_chatmethod has an excessive check, that allows raising theDialogueNotFoundexception, though I'm not sure why anybody would need this. Should we remove it?