fix img paths #681
Merged
fix img paths #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about fixing image paths as a regular PR, then making a few other changes that affect the actual code, and releasing a new patch version? Possible candidates:
They are either almost ready or easy to finish. |
|
#684 is actually a breaking change, but otherwise fine with me 👍🏻 |
WaffleLapkin
force-pushed
the
fix-img-paths
branch
from
36a4158
to
b0bfbcb
Compare
|
I've dropped the dump-version commit. |
Hirrolot
approved these changes
Jul 22, 2022
WaffleLapkin
added a commit
that referenced
this pull request
Nov 1, 2022
fix img paths Former-commit-id: 6f993ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, images in our readme only properly shown on github. However readme is also rendered on lib.rs and crates.io where our images can't be found. This should hopefully fix the issue.