-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace deprecated dist-custom-elements-bundle
dist
#1202
Conversation
Your Render PR Server URL is https://telekom-scale-storybook-preview-pr-1202.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ccdk0ek41ls3esc4sbag. |
@nowseemee and @maomaoZH please take a look if you're so kind 🙂 |
Vue and React proxy builds are also failing 💣 |
@nowseemee thanks a lot for testing this! The warning is fine. The docs explicitly say you can choose what output to configure as Also currently we get the same-but-different warning, haha. As for the proxy packages failing, I will take a look into that! 🧐 |
LGTM! Tested and it works great. |
Thanks a lot for the PR 👍 |
Amazing @maomaoZH, thanks a lot for the feedback. I'm glad it's working! — I still need to fix the issues with the builds of the wrapper packages failing (will do that after the next release, or right before if time allows) |
This is finally working now, proxy packages build (found out —assuming— the code generating the proxy packages is looking for types based on the @nowseemee, @maomaoZH please give me a final 👍 and I'll merge 🙏 |
looks great! Thanks for the fix @acstll ! |
I will add some documentation regarding this in another PR! Thanks @maomaoZH |
…with the new
dist-custom-elements
.This dist allows bypassing Stencil's lazy loading, and import only a specific set of components programatically (no magic), e.g.
See #1167