Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace deprecated dist-custom-elements-bundle dist #1202

Merged
merged 3 commits into from
Sep 28, 2022

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Sep 9, 2022

…with the new dist-custom-elements.

This dist allows bypassing Stencil's lazy loading, and import only a specific set of components programatically (no magic), e.g.

import { defineCustomElementScaleButton } from '@telekom/scale-components'

defineCustomElementScaleButton() // only `<scale-button>` is loaded

See #1167

@render
Copy link

render bot commented Sep 9, 2022

@acstll
Copy link
Collaborator Author

acstll commented Sep 9, 2022

@nowseemee and @maomaoZH please take a look if you're so kind 🙂

@acstll acstll requested a review from maomaoZH September 9, 2022 13:59
@nowseemee
Copy link
Collaborator

when building the components I get a warning, is this fine?
image

@nowseemee
Copy link
Collaborator

yarn workspace @telekom/scale-components-angular build command fails:
image

@nowseemee
Copy link
Collaborator

Vue and React proxy builds are also failing 💣

@acstll
Copy link
Collaborator Author

acstll commented Sep 12, 2022

@nowseemee thanks a lot for testing this!

The warning is fine. The docs explicitly say you can choose what output to configure as "module". It'd be nice to silent it thou.

image

Also currently we get the same-but-different warning, haha.

image

As for the proxy packages failing, I will take a look into that! 🧐

@maomaoZH
Copy link
Collaborator

LGTM! Tested and it works great.

@maomaoZH
Copy link
Collaborator

Thanks a lot for the PR 👍

@acstll
Copy link
Collaborator Author

acstll commented Sep 20, 2022

Amazing @maomaoZH, thanks a lot for the feedback. I'm glad it's working! — I still need to fix the issues with the builds of the wrapper packages failing (will do that after the next release, or right before if time allows)

@acstll
Copy link
Collaborator Author

acstll commented Sep 28, 2022

This is finally working now, proxy packages build (found out —assuming— the code generating the proxy packages is looking for types based on the types key in package.json, I had messed that up for some reason on the first try).

@nowseemee, @maomaoZH please give me a final 👍 and I'll merge 🙏

@maomaoZH
Copy link
Collaborator

looks great! Thanks for the fix @acstll !

@acstll
Copy link
Collaborator Author

acstll commented Sep 28, 2022

I will add some documentation regarding this in another PR! Thanks @maomaoZH

@acstll acstll merged commit 6bd34e9 into main Sep 28, 2022
@acstll acstll deleted the fix/update-custom-dist branch September 28, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants