Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint-plugin-jsx-a11y from 6.7.1 to 6.8.0 #3198

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 5, 2023

Bumps eslint-plugin-jsx-a11y from 6.7.1 to 6.8.0.

Changelog

Sourced from eslint-plugin-jsx-a11y's changelog.

v6.8.0 - 2023-11-01

Merged

Fixed

Commits

  • [Tests] migrate helper parsers function from eslint-plugin-react ce4d57f
  • [Refactor] use es-iterator-helpers 52de824
  • [New] mouse-events-have-key-events: add hoverInHandlers/hoverOutHandlers config db64898
  • [New] add polymorphicPropName setting for polymorphic components fffb05b
  • [Fix] isNonInteractiveElement: Upgrade aria-query to 5.3.0 and axobject-query to 3.2.1 64bfea6
  • [Refactor] use hasown instead of has 9a8edde
  • [actions] update used actions 10c061a
  • [Dev Deps] update @babel/cli, @babel/core, @babel/eslint-parser, @babel/plugin-transform-flow-strip-types, @babel/register, aud, eslint-doc-generator, eslint-plugin-import, minimist 6d5022d
  • [Dev Deps] update @babel/cli, @babel/core, @babel/eslint-parser, @babel/register, eslint-doc-generator, eslint-plugin-import 4dc7f1e
  • [New] anchor-has-content: Allow title attribute OR aria-label attribute e6bfd5c
  • [patch] mouse-events-have-key-events: rport the attribute, not the node eadd70c
  • [Deps] update @babel/runtime, array-includes, array.prototype.flatmap, object.entries, object.fromentries 46ffbc3
  • [Deps] update @babel/runtime, axobject-query, jsx-ast-utils, semver 5999555
  • [Fix] pin aria-query and axe-core to fix failing tests on main 8d8f016
  • [patch] move semver from Deps to Dev Deps 4da13e7
  • [Deps] update ast-types-flow b755318
  • [Dev Deps] update eslint-plugin-import f1c976b
  • [Deps] unpin language-tags 3d1d26d
  • [Docs] no-static-element-interactions: tabIndex is written tabindex 1271153
  • [Deps] Upgrade ast-types-flow to mitigate Docker user namespacing problems f0d2ddb
  • [Dev Deps] pin jackspeak since 2.1.2+ depends on npm aliases, which kill the install process in npm < 6 0c278f4
Commits
  • 9742753 v6.8.0
  • b755318 [Deps] update ast-types-flow
  • f1c976b [Dev Deps] update eslint-plugin-import
  • 52de824 [Refactor] use es-iterator-helpers
  • 9a8edde [Refactor] use hasown instead of has
  • 46ffbc3 [Deps] update @babel/runtime, array-includes, array.prototype.flatmap, ...
  • 4dc7f1e [Dev Deps] update @babel/cli, @babel/core, @babel/eslint-parser, `@babe...
  • fffb05b [New] add polymorphicPropName setting for polymorphic components
  • 3d1d26d [Deps] unpin language-tags
  • 10c061a [actions] update used actions
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes dependencies Used by dependabot - identifies all PRs created by dependabot javascript Pull requests that update Javascript code kind/misc Categorizes issue or PR as a miscellaneuous one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Nov 5, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign skaegi after the PR has been reviewed.
You can assign the PR to them by writing /assign @skaegi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2023
@tekton-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

/retest

@AlanGreene
Copy link
Member

This is a genuine unit-tests failure, caused by eslint rule changes with this version.

> @tektoncd/dashboard@0.1.0 lint
> eslint --ignore-path .gitignore .
/home/prow/go/src/github.com/tektoncd/dashboard/packages/components/src/components/DataTableSkeleton/DataTableSkeleton.jsx
  45:9   error  A control must be associated with a text label  jsx-a11y/control-has-associated-label
  67:13  error  A control must be associated with a text label  jsx-a11y/control-has-associated-label
✖ 2 problems (2 errors, 0 warnings)

I'll need to debug locally as there's no form control on the referenced lines, they're td elements…

@AlanGreene
Copy link
Member

Others reporting similar issue with the update: jsx-eslint/eslint-plugin-jsx-a11y#959

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/eslint-plugin-jsx-a11y-6.8.0 branch from b6cd45d to 23832c7 Compare November 6, 2023 11:57
Bumps [eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y) from 6.7.1 to 6.8.0.
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/releases)
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/CHANGELOG.md)
- [Commits](jsx-eslint/eslint-plugin-jsx-a11y@v6.7.1...v6.8.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-jsx-a11y
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/eslint-plugin-jsx-a11y-6.8.0 branch from 23832c7 to 3cb8edb Compare November 27, 2023 13:59
@tekton-robot
Copy link
Contributor

@dependabot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-dashboard-unit-tests 3cb8edb link true /test pull-tekton-dashboard-unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2024
@tekton-robot
Copy link
Contributor

@dependabot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 20, 2024

Looks like eslint-plugin-jsx-a11y is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Feb 20, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/eslint-plugin-jsx-a11y-6.8.0 branch February 20, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes dependencies Used by dependabot - identifies all PRs created by dependabot javascript Pull requests that update Javascript code kind/misc Categorizes issue or PR as a miscellaneuous one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants