AllowedIdentifiers now also checks variable assignments (rubocop#9136)

changelog/fix_allowed_identifiers_for_naming_variable_number.md

@@ -0,0 +1 @@
+* [#9136](https://github.com/rubocop-hq/rubocop/pull/9136): Fix `AllowedIdentifiers` in `Naming/VariableNumber` to include variable assignments. ([@PhilCoggins][])

lib/rubocop/cop/naming/variable_number.rb

@@ -104,6 +104,8 @@ class VariableNumber < Base
         def on_arg(node)
           @node = node
           name, = *node
+          return if allowed_identifier?(name)
+
           check_name(node, name, node.loc.name)
         end
         alias on_lvasgn on_arg
@@ -139,7 +141,7 @@ def message(style)
         end
 
         def allowed_identifier?(name)
-          allowed_identifiers.include?(name.to_s)
+          allowed_identifiers.include?(name.to_s.gsub('@', ''))
         end
 
         def allowed_identifiers

spec/rubocop/cop/naming/variable_number_spec.rb

@@ -293,6 +293,24 @@ def method1; end
       }
     end
 
+    it 'does not register an offense for a local variable name that is allowed' do
+      expect_no_offenses(<<~RUBY)
+        capture3 = :foo
+      RUBY
+    end
+
+    it 'does not register an offense for a instance variable name that is allowed' do
+      expect_no_offenses(<<~RUBY)
+        @capture3 = :foo
+      RUBY
+    end
+
+    it 'does not register an offense for a class variable name that is allowed' do
+      expect_no_offenses(<<~RUBY)
+        @@capture3 = :foo
+      RUBY
+    end
+
     it 'does not register an offense for a method name that is allowed' do
       expect_no_offenses(<<~RUBY)
         def capture3