Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: error handling for domainToASCII #1608

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

chore: error handling for domainToASCII #1608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
43cb43b
chore: error handling for domainToASCII
MichaelSun90 Feb 28, 2024
2d2dcf5
chore: remove only
MichaelSun90 Feb 28, 2024
74f95ba
Merge branch 'master' into michael-domainErrorHandling
MichaelSun90 Feb 29, 2024
fa781dd
chore: match the behavior with pervious
MichaelSun90 Mar 6, 2024
9284dc3
Merge branch 'master' into michael-domainErrorHandling
MichaelSun90 Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/connector.ts
View file
Open in desktop
Expand Up @@ -164,7 +164,8 @@ export async function lookupAllAddresses(host: string, lookup: LookupFunction, s

signal.addEventListener('abort', onAbort);

lookup(url.domainToASCII(host), { all: true }, (err, addresses) => {
const domainInASCII = url.domainToASCII(host);
lookup(domainInASCII === '' ? host : domainInASCII, { all: true }, (err, addresses) => {
signal.removeEventListener('abort', onAbort);

err ? reject(err) : resolve(addresses);
Expand Down
5 changes: 2 additions & 3 deletions src/sender.ts
View file
Open in desktop
Expand Up @@ -80,9 +80,8 @@ export async function sendMessage(host: string, port: number, lookup: LookupFunc
reject(new AbortError());
};

signal.addEventListener('abort', onAbort);

lookup(url.domainToASCII(host), { all: true }, (err, addresses) => {
const domainInASCII = url.domainToASCII(host);
lookup(domainInASCII === '' ? host : domainInASCII, { all: true }, (err, addresses) => {
signal.removeEventListener('abort', onAbort);

err ? reject(err) : resolve(addresses);
Expand Down