ci: improve github actions #1573
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1573 +/- ##
==========================================
- Coverage 80.45% 79.53% -0.92%
==========================================
Files 92 92
Lines 4692 4692
Branches 871 871
==========================================
- Hits 3775 3732 -43
- Misses 644 689 +45
+ Partials 273 271 -2 |
The setup-node action automatically stores caches for NPM and uses the same logic as the current action implementation, so there's no need to duplicate it in the action definition.
The npm upgrade steps in CI only run if the matrix version for node is 6.x but 6.x is not a tested version of node in any of the matrix definitions.
The linting step does not need the entire repository history to run. Only checkout the minimal history to allow faster lint step.
dhensby
force-pushed
the
pulls/action-improvements
branch
3 times, most recently
from
04e5199
to
a4a44cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More to come...