Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: refactor connection internals #1562

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
0a0fb70
refactor: remove `enter` event of `FINAL` state
arthurschreiber Jul 25, 2023
48e6720
refactor: extract `enter` event logic from `SENT_LOGIN7_WITH_STANDARD…
arthurschreiber Jul 25, 2023
41ab30a
refactor: extract more `enter` event logic from `SENT_LOGIN7` states
arthurschreiber Jul 25, 2023
bbb3875
refactor: remove `enter` event for `CONNECTING` state
arthurschreiber Jul 25, 2023
738dc6d
refactor: remove `enter` event for `REROUTING` state
arthurschreiber Jul 25, 2023
8f7808c
refactor: remove `enter` event for `LOGGED_IN_SENDING_INITIAL_SQL` state
arthurschreiber Jul 25, 2023
df40cee
refactor: remove `enter` event for `SENT_LOGIN7_WITH_STANDARD_LOGIN` …
arthurschreiber Jul 25, 2023
c3e6123
refactor: remove `enter` event for `SENT_LOGIN7_WITH_NTLM` state
arthurschreiber Jul 25, 2023
9bdb533
refactor: remove `enter` event for `SENT_LOGIN7_WITH_FEDAUTH` state
arthurschreiber Jul 25, 2023
60cd91c
refactor: move logic around
arthurschreiber Jul 25, 2023
59dfb25
fixup: fix missing `loggedInSendingInitialSql` call
arthurschreiber Jul 25, 2023
ab6da05
refactor: remove `reconnect` event from `REROUTING` state
arthurschreiber Jul 25, 2023
ee34498
refactor: remove `enter` event from `TRANSIENT_FAILURE_RETRY` state
arthurschreiber Jul 25, 2023
a8233a3
refactor: remove `retry` event in `TRANSIENT_FAILURE_RETRY` state
arthurschreiber Jul 25, 2023
9d87e1c
refactor: move logic around
arthurschreiber Jul 25, 2023
f3ecdd9
refactor: rename method
arthurschreiber Jul 25, 2023
3b8a64d
refactor: pass the connect timeout signal along the different connect…
arthurschreiber Jul 25, 2023
34e0c26
refactor: rename methods
arthurschreiber Jul 25, 2023
723b693
refactor: further code cleanup
arthurschreiber Jul 25, 2023
5e82051
fixup: add missing await call
arthurschreiber Jul 25, 2023
3434c39
refactor: await on `loggedInSendingInitialSql`
arthurschreiber Jul 25, 2023
043a238
refactor: make more use of `async`/`await`
arthurschreiber Jul 25, 2023
5a1fe28
refactor: remove `connectTimeout` event
arthurschreiber Jul 25, 2023
021c7d9
refactor: extract reroute handling
arthurschreiber Jul 25, 2023
d1dd53b
refactor: extract retry handling
arthurschreiber Jul 25, 2023
0d9ca14
refactor: further retry cleanup
arthurschreiber Jul 25, 2023
1052b37
refactor: get rid of the retry timeout property
arthurschreiber Jul 25, 2023
2662fcb
refactor: add signal parameters
arthurschreiber Jul 25, 2023
07edcb0
refactor: extract error wrapping
arthurschreiber Jul 25, 2023
068ac76
refactor: simplify error handling during connection open
arthurschreiber Jul 25, 2023
adf490b
fixup: wait for connections to be closed
arthurschreiber Jul 25, 2023
b2e1f27
Merge branch 'master' into arthur/connection-refactor
arthurschreiber Aug 6, 2023
700d840
Merge branch 'master' into arthur/connection-refactor
arthurschreiber Aug 6, 2023
7183dd7
Merge branch 'master' of https://github.com/tediousjs/tedious into ar…
arthurschreiber Sep 17, 2023
8ad7774
Further cleanups.
arthurschreiber Sep 19, 2023
14329d8
Convert `makeRequest` internals to `async`/`await`.
arthurschreiber Sep 20, 2023
9b2be0b
move response handling into `makeRequest`
arthurschreiber Sep 20, 2023
a836131
Cleanup response handling code to use scope local `request`.
arthurschreiber Sep 20, 2023
40f7c7a
Remove `_cancelAfterRequestSent` connection property
arthurschreiber Sep 20, 2023
ada474c
Drop `TokenStreamParser` wrapper.
arthurschreiber Sep 20, 2023
b846990
Move attention signal handling into `makeRequest`.
arthurschreiber Sep 21, 2023
d4b9646
Remove `enter` state handler.
arthurschreiber Sep 21, 2023
93dcc03
Ensure `cancel` handler gets cleaned up.
arthurschreiber Sep 21, 2023
8568018
Reduce duplicated logic.
arthurschreiber Sep 21, 2023
4c86e2d
Use `request` local var.
arthurschreiber Sep 21, 2023
335313c
Fix benchmark deprecation message.
arthurschreiber Sep 25, 2023
08c2a03
massive refactoring changes.
arthurschreiber Sep 27, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/common.js
Expand Up @@ -65,7 +65,7 @@ function Benchmark(fn, configs, options) {

for (let i = 0; i < length; i++) {
const entry = entries[i];
const stats = this._gcStats[entry.kind];
const stats = this._gcStats[entry.detail.kind];

if (stats) {
stats.count += 1;
Expand Down