Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: skip config validation when using connector #1542

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: skip config validation when using connector #1542

wants to merge 2 commits into from

Commits on Jul 24, 2023

  1. fix: skip config validation when using connector 

    This changeset fixes a problem in the original custom `connector`
factory method implementation that required the `server` config property
to be defined even though its value is ignored.

Removing the validation when `config.options.connector` is defined fixes
the problem.

Ref: tediousjs#1540
Fixes: tediousjs#1541
Signed-off-by: Ruy Adorno <ruyadorno@google.com>
    @ruyadorno
    ruyadorno committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    634c947 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Merge branch 'master' into fix-config-validation-when-using-connector… 

    …-factory-method
    @arthurschreiber
    arthurschreiber committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    faff247 View commit details
    Browse the repository at this point in the history