refactor: add additional parsers and tests #1524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## arthur/parser-combinator #1524 +/- ##
============================================================
- Coverage 76.54% 75.16% -1.38%
============================================================
Files 92 92
Lines 4950 5014 +64
Branches 922 936 +14
============================================================
- Hits 3789 3769 -20
- Misses 858 947 +89
+ Partials 303 298 -5
|
mShan0
commented
Feb 28, 2023
Comment on lines
+639
to
+649
| // Temporary buffers to convert numbers. | ||
| const float32Array = new Float32Array(1); | ||
| const uInt8Float32Array = new Uint8Array(float32Array.buffer); | ||
| const float64Array = new Float64Array(1); | ||
| const uInt8Float64Array = new Uint8Array(float64Array.buffer); | ||
|
|
||
| // Check endianness. | ||
| float32Array[0] = -1; // 0xBF800000 | ||
| // Either it is [0, 0, 128, 191] or [191, 128, 0, 0]. It is not possible to | ||
| // check this with `os.endianness()` because that is determined at compile time. | ||
| const bigEndian = uInt8Float32Array[3] === 0; |
There was a problem hiding this comment.
Taken from base Node buffer.js
mShan0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following parsers:
Adds tests for these parsers: