Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use docker compose to run sql server with custom tls certificate in GitHub Actions. #1523

Merged
merged 9 commits into from
Mar 22, 2023

Conversation

arthurschreiber
Copy link
Collaborator

@arthurschreiber arthurschreiber commented Feb 12, 2023

This changes the GitHub Action builds to use docker compose to start a SQL Server instance with a custom mssql.conf file that enables the use of a custom self-signed certificate. This certificate is also used when connecting to the SQL Server.

@arthurschreiber arthurschreiber force-pushed the arthur/enable-tls-in-github-actions branch from 3b2f543 to 7dcf948 Compare February 12, 2023 14:15
@arthurschreiber arthurschreiber force-pushed the arthur/enable-tls-in-github-actions branch from d7c5a31 to 6260e76 Compare February 12, 2023 14:40
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #1523 (6f96d7a) into master (4359f58) will decrease coverage by 0.95%.
The diff coverage is n/a.

❗ Current head 6f96d7a differs from pull request most recent head c2c275c. Consider uploading reports for the commit c2c275c to get more accurate results

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
- Coverage   80.58%   79.63%   -0.95%     
==========================================
  Files          91       91              
  Lines        4655     4655              
  Branches      854      854              
==========================================
- Hits         3751     3707      -44     
- Misses        629      681      +52     
+ Partials      275      267       -8     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arthurschreiber arthurschreiber changed the title Try using docker compose to run sql server in GitHub Actions. ci: use docker compose to run sql server with custom tls certificate in GitHub Actions. Mar 22, 2023
@arthurschreiber arthurschreiber marked this pull request as ready for review March 22, 2023 22:35
@arthurschreiber arthurschreiber merged commit ac23db7 into master Mar 22, 2023
@arthurschreiber arthurschreiber deleted the arthur/enable-tls-in-github-actions branch March 22, 2023 22:37
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

🎉 This PR is included in version 16.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

AdamJohnSwan pushed a commit to AdamJohnSwan/tedious that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant