Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Comment About A Request Lasting Longer Than Its Timeout #1486

Merged

Conversation

AdamJohnSwan
Copy link
Contributor

Issue: #1485

Queries that return a response before finishing have ability to run longer than the requestTimeout.
When a response is received the timeout for the request is cancelled. This is because it can't be known what the client will do with the response.

@AdamJohnSwan AdamJohnSwan changed the title Add Comment About A Request Lasting Longer Than Its Timeout docs: Add Comment About A Request Lasting Longer Than Its Timeout Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #1486 (603f623) into master (ece396a) will decrease coverage by 0.77%.
The diff coverage is 55.55%.

❗ Current head 603f623 differs from pull request most recent head 2ae8773. Consider uploading reports for the commit 2ae8773 to get more accurate results

@@            Coverage Diff             @@
##           master    #1486      +/-   ##
==========================================
- Coverage   80.48%   79.71%   -0.77%     
==========================================
  Files          91       91              
  Lines        4657     4659       +2     
  Branches      856      856              
==========================================
- Hits         3748     3714      -34     
- Misses        633      677      +44     
+ Partials      276      268       -8     
Impacted Files Coverage Δ
src/connection.ts 61.84% <55.55%> (-3.40%) ⬇️

... and 4 files with indirect coverage changes

@AdamJohnSwan
Copy link
Contributor Author

@arthurschreiber Is this description okay? Are you able to merge?

Copy link
Contributor

@MichaelSun90 MichaelSun90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

@arthurschreiber arthurschreiber merged commit ed02374 into tediousjs:master Jun 7, 2023
17 of 22 checks passed
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

🎉 This PR is included in version 16.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AdamJohnSwan AdamJohnSwan deleted the RequestTimeoutComment branch July 3, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants