Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove callback nesting from parsers #1477

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mShan0
Copy link
Contributor

@mShan0 mShan0 commented Aug 5, 2022

Continues the refactor of parsers based on #1448.

Refactors the following token parsers:

  • LoginAck
  • Order
  • ReturnStatus
  • Info and Error
  • metadataParse portion of ColumnMetadata

Buffer read functions are in in a separate file/class

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #1477 (a0eebf9) into master (5015634) will decrease coverage by 0.42%.
The diff coverage is 82.58%.

@@            Coverage Diff             @@
##           master    #1477      +/-   ##
==========================================
- Coverage   80.50%   80.08%   -0.43%     
==========================================
  Files          91       92       +1     
  Lines        4669     4750      +81     
  Branches      856      865       +9     
==========================================
+ Hits         3759     3804      +45     
- Misses        634      670      +36     
  Partials      276      276              
Impacted Files Coverage Δ
src/value-parser.ts 81.72% <50.00%> (-0.23%) ⬇️
src/token/colmetadata-token-parser.ts 71.73% <62.50%> (-4.46%) ⬇️
src/token/returnvalue-token-parser.ts 71.42% <62.50%> (-17.47%) ⬇️
src/token/returnstatus-token-parser.ts 70.00% <66.66%> (-30.00%) ⬇️
src/token/infoerror-token-parser.ts 72.72% <72.72%> (-27.28%) ⬇️
src/token/order-token-parser.ts 80.00% <78.57%> (-20.00%) ⬇️
src/token/loginack-token-parser.ts 85.00% <83.33%> (-15.00%) ⬇️
src/metadata-parser.ts 92.59% <92.30%> (+0.59%) ⬆️
src/token/buffer-reader.ts 92.68% <92.68%> (ø)
src/token/stream-parser.ts 71.65% <0.00%> (-2.14%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant