Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: out-of-range date error handle #1271

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

IanChokS
Copy link
Member

Fixes #1265

  • Add fix to properly throw error on invalid / out-of-range Date objects

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (57998f2) 79.00% compared to head (3b6ec51) 78.94%.

Files Patch % Lines
src/data-types/smalldatetime.ts 63.63% 2 Missing and 2 partials ⚠️
src/data-types/datetime.ts 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
- Coverage   79.00%   78.94%   -0.07%     
==========================================
  Files          93       93              
  Lines        4821     4839      +18     
  Branches      921      927       +6     
==========================================
+ Hits         3809     3820      +11     
- Misses        709      710       +1     
- Partials      303      309       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception thrown from SmallDateTime/generateParameterData cannot be caught properly
3 participants