Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #24
This PR DOES NOT WORK YET. I'm opening it to start a discussion on how we should approach this problem. My current approach seems tedious. There must be a better way.
There are a lot of subtle problems with python3 (the testsuite does not pass yet).
The testsuite passes on python2 (except for
AWS4Auth_GetCanonicalHeaders_Test.test_headers_amz_example
which did not pass before my changes either).This PR might not be necessary at all if kennethreitz/requests#3573 is fixed. Although there might be more subtleties, because:
current python3 testsuite output: https://gist.github.com/stefanfoulis/1c9b46a61beba2e6423caa746006cae0