Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jquery and jquery_ui #2503

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update jquery and jquery_ui #2503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b3d3bd
Update jquery and jquery_ui
twalpole Oct 23, 2021
2e8c10b
Updating to JQuery 3.x somehow changes the visibility calculation - w…
twalpole Oct 24, 2021
973c908
Update to latest jquery/jquery-ui in teh specs
twalpole Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 4 additions & 11 deletions lib/capybara/spec/public/jquery-ui.js
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 2 additions & 5 deletions lib/capybara/spec/public/jquery.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/capybara/spec/session/fill_in_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@
@session.fill_in('with_change_event', with: '')
# click outside the field to trigger the change event
@session.find(:css, 'h1', text: 'FooBar').click
expect(@session).to have_selector(:css, '.change_event_triggered', match: :one)
expect(@session).to have_selector(:css, '.change_event_triggered', match: :one, visible: :all)
end
end

Expand Down
6 changes: 3 additions & 3 deletions spec/shared_selenium_session.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
session.fill_in('with_change_event', with: '')
# click outside the field to trigger the change event
session.find(:css, 'body').click
expect(session).to have_selector(:css, '.change_event_triggered', match: :one)
expect(session).to have_selector(:css, '.change_event_triggered', visible: :all, match: :one)
end
end

Expand Down Expand Up @@ -134,7 +134,7 @@
fill_options: { clear: :backspace })
# click outside the field to trigger the change event
session.find(:css, '#with_focus_event').click
expect(session).to have_selector(:css, '.change_event_triggered', match: :one, wait: 5)
expect(session).to have_selector(:css, '.change_event_triggered', visible: :all, match: :one, wait: 5)
end

it 'should trigger input event field_value.length times' do
Expand All @@ -145,7 +145,7 @@
# click outside the field to trigger the change event
# session.find(:css, 'body').click
session.find(:css, 'h1', text: 'FooBar').click
expect(session).to have_xpath('//p[@class="input_event_triggered"]', count: 13)
expect(session).to have_xpath('//p[@class="input_event_triggered"]', count: 13, visible: :all)
end
end

Expand Down