Expand click_on beyond just an alias of click_link_or_button
#2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6119
💛 - Coveralls |
twalpole
force-pushed
the
click_on
branch
4 times, most recently
from
dc7b23f
to
c026f0f
Compare
twalpole
force-pushed
the
click_on
branch
4 times, most recently
from
fa3211b
to
d0cd651
Compare
twalpole
force-pushed
the
click_on
branch
2 times, most recently
from
155e758
to
11d9811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
click_onfrom just an alias ofclick_link_or_buttoninto a shortcut forfind(...).click, by allowing it to accept a selector type. It defaults to a selector type oflink_or_buttonto retain previous behavior as the default. I'm not 100% sold on this being a good idea yet.