Add browser local/session storage option #1853
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalpole
force-pushed
the
browser_storage_clearing
branch
2 times, most recently
from
a292e29
to
9bf791f
Compare
|
Do you want to keep Selenium-specific option (#1781) as well? |
|
I was thinking about deprecating them, but hadn't fully decided - The issue with those options is that they can't clear the storage in all conditions (if storage is saved in an onunload handler) so they're not perfect. I'm also trying to decide whether the new version should support specifying to clear the session or local storage - or whether it should just be both as it is now. Thoughts? |
twalpole
force-pushed
the
browser_storage_clearing
branch
from
d19c053
to
58bfda6
Compare
twalpole
force-pushed
the
browser_storage_clearing
branch
from
58bfda6
to
174b98e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a setting to clear localStorage and sessionStorage on reset if Capybara is running the server for the session.