New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement debug output for file and websocket #352

Merged

farhat-ha merged 1 commit into main from haythem/debugging

Apr 26, 2024

Collaborator

farhat-ha commented Apr 26, 2024

Describe your changes

📝 To Do

All linters pass
All tests pass
Change documentation based on my changes

✋ Manual testing

Provide manual testing instructions

🦊 Browser testing

Desktop

Edge (latest)
Chrome
Firefox
Safari

📸 Screenshots

Description	Screenshot
Desktop
usage.gif

farhat-ha force-pushed the haythem/debugging branch from b55e4a8 to cd5db67 Compare

April 26, 2024 14:46

DeividVeloso approved these changes

View reviewed changes

Contributor

DeividVeloso left a comment

LGTM

enzoqtvf reviewed

View reviewed changes

enzoqtvf left a comment

small question regarding the default value of debug

Also probably we want to add extra documentation regarding what it does. this can be added later though

packages/js/README.md Outdated Show resolved Hide resolved

farhat-ha requested review from a team, ericaprieto, lmao12, jonathan-telnyx and priscillasantana

April 26, 2024 14:51


          feat: implement debug output for file and websocket

farhat-ha force-pushed the haythem/debugging branch from cd5db67 to 6634658 Compare

April 26, 2024 14:53

farhat-ha merged commit 8d1f8e6 into main

2 checks passed

farhat-ha deleted the haythem/debugging branch

April 26, 2024 14:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

enzoqtvf enzoqtvf left review comments

DeividVeloso DeividVeloso approved these changes

ericaprieto Awaiting requested review from ericaprieto ericaprieto was automatically assigned from team-telnyx/frontend

lmao12 Awaiting requested review from lmao12 lmao12 was automatically assigned from team-telnyx/frontend

jonathan-telnyx Awaiting requested review from jonathan-telnyx jonathan-telnyx was automatically assigned from team-telnyx/frontend

priscillasantana Awaiting requested review from priscillasantana priscillasantana was automatically assigned from team-telnyx/frontend