Fix unzipping of kindlegen archive on Windows #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unzipping was broken due to fixes for CVE-2018-1000544 in rubyzip: [1], [2]. Also, see [3]. Fixes tdtds#32. [1]: rubyzip/rubyzip#371 [2]: rubyzip/rubyzip#376 [3]: rubyzip/rubyzip#354
|
It would also be great that you publish a release when this is merged because, as #32 says, it is currently impossible to install existing kindlegen releases on Windows. |
|
LGTM, thanks @slonopotamus !! I'll release new version soon. |
slonopotamus
added a commit
to slonopotamus/asciidoctor-epub3
that referenced
this pull request
Dec 24, 2019
Previous kindlegen releases are unable to install in Windows. See tdtds/kindlegen#33
slonopotamus
added a commit
to slonopotamus/asciidoctor-epub3
that referenced
this pull request
Dec 24, 2019
Previous kindlegen releases are unable to install in Windows. See tdtds/kindlegen#33
mojavelinux
pushed a commit
to asciidoctor/asciidoctor-epub3
that referenced
this pull request
Dec 25, 2019
Previous kindlegen releases are unable to install in Windows. See tdtds/kindlegen#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unzipping was broken due to fixes for CVE-2018-1000544 in rubyzip: 1, 2.
Also, see 3.
Fixes #32.