Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Array#groupBy and Array#groupByToMap to Array#group and Array#groupToMap #3632

Merged
merged 1 commit into from Aug 3, 2022
Merged

Rename Array#groupBy and Array#groupByToMap to Array#group and Array#groupToMap #3632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion features.txt
View file
Open in desktop
Expand Up @@ -260,7 +260,7 @@ ShadowRealm
# https://github.com/tc39/proposal-array-find-from-last
array-find-from-last

# Array.prototype.groupBy & Array.prototype.groupByToMap
# Array.prototype.group & Array.prototype.groupToMap
# https://github.com/tc39/proposal-array-grouping
array-grouping

Expand Down
20 changes: 10 additions & 10 deletions test/built-ins/Array/prototype/Symbol.unscopables/array-grouping.js
View file
Open in desktop
Expand Up @@ -8,8 +8,8 @@ info: |
22.1.3.32 Array.prototype [ @@unscopables ]

...
10. Perform ! CreateDataPropertyOrThrow(unscopableList, "groupBy", true).
11. Perform ! CreateDataPropertyOrThrow(unscopableList, "groupByToMap", true).
10. Perform ! CreateDataPropertyOrThrow(unscopableList, "group", true).
11. Perform ! CreateDataPropertyOrThrow(unscopableList, "groupToMap", true).
...

includes: [propertyHelper.js]
Expand All @@ -20,12 +20,12 @@ var unscopables = Array.prototype[Symbol.unscopables];

assert.sameValue(Object.getPrototypeOf(unscopables), null);

assert.sameValue(unscopables.groupBy, true, '`groupBy` property value');
verifyEnumerable(unscopables, 'groupBy');
verifyWritable(unscopables, 'groupBy');
verifyConfigurable(unscopables, 'groupBy');
assert.sameValue(unscopables.group, true, '`group` property value');
verifyEnumerable(unscopables, 'group');
verifyWritable(unscopables, 'group');
verifyConfigurable(unscopables, 'group');

assert.sameValue(unscopables.groupByToMap, true, '`groupByToMap` property value');
verifyEnumerable(unscopables, 'groupByToMap');
verifyWritable(unscopables, 'groupByToMap');
verifyConfigurable(unscopables, 'groupByToMap');
assert.sameValue(unscopables.groupToMap, true, '`groupToMap` property value');
verifyEnumerable(unscopables, 'groupToMap');
verifyWritable(unscopables, 'groupToMap');
verifyConfigurable(unscopables, 'groupToMap');