This repository has been archived by the owner on Feb 19, 2021. It is now read-only.
Make non-global RegExps global so they can "replace all" occurrences #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one of the potential solutions to #16.
ExE-Boss
approved these changes
Jul 18, 2019
|
Alternative approach: #24 |
ljharb
suggested changes
Sep 18, 2019
| <emu-alg> | ||
| 1. Let _rx_ be the *this* value. | ||
| 1. If Type(_rx_) is not Object, throw a *TypeError* exception. | ||
| 1. Let _flags_ be ? ToString(? Get(_rx_, `"flags"`)). |
There was a problem hiding this comment.
if flags is undefined, this should be the empty string, not the string undefined, to match the RegExp constructor.
|
We're going with #24 instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the potential solutions to #16.