remove hint from GetIteratorFlattenable #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
commented
Mar 30, 2023
spec.html
Outdated
| 1. Set _alreadyAsync_ to *false*. | ||
| 1. If IsCallable(_method_) is *false*, then | ||
| 1. Let _method_ be ? GetMethod(_obj_, @@iterator). | ||
| 1. If _method_ is *undefined*, then |
There was a problem hiding this comment.
This change from Get/IsCallable to GetMethod/undefined is technically normative, but it more closely matches the existing GetIterator behaviour. If obj has a Symbol.iterator property that is non-callable, it will now throw instead of falling back to treating obj as an iterator.
There was a problem hiding this comment.
I've removed this to split it into a separate PR.
edit: See #272.
michaelficarra
commented
Mar 30, 2023
| 1. Let _iterator_ be _obj_. | ||
| 1. Set _alreadyAsync_ to *true*. | ||
| 1. Else, | ||
| 1. Let _iterator_ be ? Call(_method_, _obj_). | ||
| 1. If _iterator_ is not an Object, throw a *TypeError* exception. | ||
| 1. Let _nextMethod_ be ? Get(_iterator_, *"next"*). | ||
| 1. If IsCallable(_nextMethod_) is *false*, throw a *TypeError* exception. |
There was a problem hiding this comment.
This line diverges from GetIterator but the early failure is IMO better. See related tc39/ecma262#3033.
bakkot
approved these changes
Mar 30, 2023
bakkot
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been included with #263.