Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Stage 4 Criteria #32

Closed
10 tasks
jridgewell opened this issue Dec 14, 2021 · 8 comments
Closed
10 tasks

Stage 4 Criteria #32

jridgewell opened this issue Dec 14, 2021 · 8 comments

Comments

@jridgewell
Copy link
Member

jridgewell commented Dec 14, 2021

@legendecas
Copy link
Member

V8 Tracking issue: https://bugs.chromium.org/p/v8/issues/detail?id=12499&q=array%20grouping&can=2

@zloirock
Copy link
Contributor

It's available in FF Nightly 105, but I can't find the issue.

@bakkot
Copy link
Contributor

bakkot commented Jul 27, 2022

Firefox issue is https://bugzilla.mozilla.org/show_bug.cgi?id=1739648. Still nightly-only, though.

webkit-early-warning-system pushed a commit to Constellation/WebKit that referenced this issue Aug 4, 2022
https://bugs.webkit.org/show_bug.cgi?id=243510

Reviewed by Mark Lam, Justin Michaud, Devin Rousso and Ross Kirsling.

We agreed at TC39 to renaming Array#groupBy and Array#groupByToMap to Array#group and Array#groupToMap
to keep web-compatibility. This patch renames and enables them, stage-4 progress is tracked in [1].
We also upstreamed test262 fix for this[2].

[1]: tc39/proposal-array-grouping#32
[2]: tc39/test262#3632

* Source/JavaScriptCore/builtins/ArrayPrototype.js:
(group):
(groupToMap):
(groupBy): Deleted.
(groupByToMap): Deleted.
* Source/JavaScriptCore/runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/253101@main
@bakkot
Copy link
Contributor

bakkot commented Sep 27, 2022

Looks like Chrome is also shipping in Canary. All three major engines now have this shipping in their nightly builds.

Chrome platform status says this is expected to go out in 108, which is due to be released November 29.

@andylima
Copy link

Chrome platform status says this is expected to go out in 108, which is due to be released November 29.

Yes, I've just confirmed it's in Chrome 108 Beta. 🙂

@codehag
Copy link

codehag commented Nov 7, 2022

@andylima @syg It looks like we have another regression, this time with group: https://bugzilla.mozilla.org/show_bug.cgi?id=1791415 -- this was more difficult to catch than the last one.

@ljharb
Copy link
Member

ljharb commented Nov 7, 2022

#44

@ljharb
Copy link
Member

ljharb commented May 18, 2023

Closing, per #54.

@ljharb ljharb closed this as completed May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants