Normative: add Reflect[Symbol.toStringTag]
#2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
normative change
ljharb
added a commit
to tc39/agendas
that referenced
this pull request
Jun 19, 2020
|
Just putting a note in here to also discuss the |
michaelficarra
approved these changes
Jul 16, 2020
ljharb
added
has consensus
|
Consensus for this change, as well as the future principle of "consistency" for |
|
Tests: tc39/test262#2710 |
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Jul 20, 2020
see tc39/ecma262#2057 Co-authored-by: Leo Balter <leonardo.balter@gmail.com>
leobalter
added a commit
to tc39/test262
that referenced
this pull request
Jul 20, 2020
Ref tc39/ecma262#2057 Co-authored-by: Leo Balter <leonardo.balter@gmail.com>
ljharb
added
has test262 tests
and removed
needs test262 tests
This was referenced Jul 21, 2020
domenic
pushed a commit
to whatwg/webidl
that referenced
this pull request
Jul 23, 2020
A followup to #357. This change aligns WebIDL namespace objects with ECMA-262 ones, per tc39/ecma262#2057 (comment). Tests: web-platform-tests/wpt#24717
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Jul 25, 2020
Summary: ECMA262 PR: tc39/ecma262#2057 Reviewed By: mhorowitz Differential Revision: D22737738 fbshipit-source-id: 275a890c5d304bebb83643ebcc6bdf6299dc6898
pull bot
pushed a commit
to ashu8912/v8
that referenced
this pull request
Jul 30, 2020
This normative PR reached consensus in the July 2020 TC39: tc39/ecma262#2057 Bug: v8:10768 Change-Id: Ibe2affea0447b923435f77de5d3c0233deeb9877 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2327753 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#69156}
zloirock
added a commit
to zloirock/core-js
that referenced
this pull request
Nov 4, 2020
JLHwung
added a commit
to JLHwung/babel-polyfills
that referenced
this pull request
Aug 30, 2021
JLHwung
added a commit
to JLHwung/babel-polyfills
that referenced
this pull request
Sep 2, 2021
JLHwung
added a commit
to JLHwung/babel-polyfills
that referenced
this pull request
Sep 7, 2021
JLHwung
added a commit
to JLHwung/babel-polyfills
that referenced
this pull request
Sep 20, 2021
JLHwung
added a commit
to babel/babel-polyfills
that referenced
this pull request
Oct 8, 2021
* support new proposals * update test fixtures * address review comments * Add common iterators to Iterator dependencies * fix JSON stringify polyfill descriptors * add CommonIterators to (Async)Iterator.from * support es.string.substr and add es.regexp.exec to matchAll/replaceAll * add es.regexp.test support * chore: generate shippedProposals from corejs3 compat data * support Reflect[@@toStringTag] tc39/ecma262#2057 * fix typo * update core-js-compat to 3.17.0 * add global Reflect dependencies * ignore shipped proposals * fix: use string version in test fixtures * update to core-js-compat 3.17.1 * add annex b features * remove type array instance methods They are supported in constructor dependencies * add iterator dependencies to iterator helpers * fix object.at not polyfilled in pure mode * esnext.array.unique-by depends on es.map * chore: update core-js-compat to 3.18.0 * feat: support Array.fromAsync * Update packages/babel-plugin-polyfill-corejs3/test/check-builtin-definitions.test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1970.
Essentially, this PR makes Reflect no longer be the "odd one out" - ie, the only namespace-like builtin object that lacks a
Symbol.toStringTag.See also: tc39/ecma402#430